Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libboost-coroutine(-dev) to rosdep #35789

Merged
merged 4 commits into from Feb 21, 2023
Merged

Conversation

BartKeulen
Copy link
Contributor

Please add the following dependency to the rosdep database.

Package name:

  • libboost-coroutine
  • libboost-coroutine-dev

Package Upstream Source:

Purpose of using this:

Useful when you only want to install the boost coroutine library and not the full boost library.

Links to Distribution Packages

libboost-coroutine

libboost-coroutine-dev

@BartKeulen BartKeulen requested a review from a team as a code owner January 9, 2023 09:54
@github-actions github-actions bot added the rosdep Issue/PR is for a rosdep key label Jan 9, 2023
tfoote
tfoote previously requested changes Jan 13, 2023
Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Please resolve the RHEL 7 linter error then it lgtm.

rosdep/base.yaml Outdated Show resolved Hide resolved
@clalancette clalancette added the changes requested Maintainers have asked for changes to the pull request label Jan 18, 2023
@nuclearsandwich
Copy link
Member

@BartKeulen is this PR something you are still interested in? If not can it be closed?

Co-authored-by: Tully Foote <tully.foote@gmail.com>
@BartKeulen
Copy link
Contributor Author

@BartKeulen is this PR something you are still interested in? If not can it be closed?

Yes, I am still interested. Apologies it took a while.

Copy link
Contributor

@emersonknapp emersonknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now, thanks for the followup

@emersonknapp emersonknapp self-requested a review February 15, 2023 18:45
Copy link
Contributor

@emersonknapp emersonknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more quick addition for Alpine should make the tests happy

rosdep/base.yaml Outdated Show resolved Hide resolved
rosdep/base.yaml Show resolved Hide resolved
Bart Keulen and others added 2 commits February 17, 2023 13:28
Co-authored-by: Emerson Knapp <537409+emersonknapp@users.noreply.github.com>
Co-authored-by: Emerson Knapp <537409+emersonknapp@users.noreply.github.com>
@mjcarroll mjcarroll merged commit ecf863b into ros:master Feb 21, 2023
BartKeulen added a commit to BartKeulen/BehaviorTree.CPP that referenced this pull request Mar 2, 2023
`libboost-coroutine-dev` has been merged into rosdistro on February 21st
2023. Link to merge request: ros/rosdistro#35789.
facontidavide pushed a commit to BehaviorTree/BehaviorTree.CPP that referenced this pull request Mar 3, 2023
`libboost-coroutine-dev` has been merged into rosdistro on February 21st
2023. Link to merge request: ros/rosdistro#35789.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested Maintainers have asked for changes to the pull request rosdep Issue/PR is for a rosdep key
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants