Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #6: No robot model when using display.launch (again) #7

Merged
merged 3 commits into from Jan 9, 2014

Conversation

@gavanderhoorn
Copy link
Contributor

gavanderhoorn commented Jan 5, 2014

This pull request should actually fix the issues. I think the proposed file and directory layout is in line with other packages containing URDFs and launch files.

Doing it this way does require us updating the tutorials, as the URDFs are now in the urdf subdirectory.

PS: I left the urdf.vcg file in, although AFAIK those are not used anymore (old RViz config file?).

@gavanderhoorn

This comment has been minimized.

Copy link
Contributor Author

gavanderhoorn commented Jan 9, 2014

Ping?

isucan added a commit that referenced this pull request Jan 9, 2014
…stall

Fix issue #6: No robot model when using display.launch (again)
@isucan isucan merged commit 766363b into ros:master Jan 9, 2014
@gavanderhoorn

This comment has been minimized.

Copy link
Contributor Author

gavanderhoorn commented Jan 9, 2014

Thanks. Should we update the tutorial pages now, or when this is released?

@gavanderhoorn gavanderhoorn deleted the gavanderhoorn:issue6_source_vs_devel_vs_install branch Jan 9, 2014
@isucan

This comment has been minimized.

Copy link
Contributor

isucan commented Jan 9, 2014

Can you update it now? I will trigger a release now for Hydro. Should I release for Groovy as well?

@gavanderhoorn

This comment has been minimized.

Copy link
Contributor Author

gavanderhoorn commented Jan 9, 2014

I can update them.

Should I release for Groovy as well?

Well AFAIK the package is currently broken in both Hydro and Groovy, so I guess it should be rereleased in both?

@gavanderhoorn

This comment has been minimized.

Copy link
Contributor Author

gavanderhoorn commented Jan 9, 2014

I've updated the wiki pages I could find. There are still some bits that seem outdated (references to urdf_tools package etc) though.

@isucan

This comment has been minimized.

Copy link
Contributor

isucan commented Jan 9, 2014

Packages released for both hydro & groovy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.