-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should urdf_parser_py be in a different repo? #70
Comments
+1 for separate repo |
should I move it to robot_model or make a new repo entirely for urdf_parser_py? |
I would move it to a new urdf_parser_py |
Distributing |
@traversaro I'll keep cross-platform compatibility in mind when I do this. |
@jacquelinekay I noticed that catkin is also distributed through pip, so perhaps it is not so traumatic to install it on Windows. |
Windows development is usually traumatic for me :P |
With regards to your concerns, Silvio, my vision is for urdf_parser_py to be cross-platform and ROS-free, and to have a separate catkin package in the I confirmed with Ioan that urdf_parser_py is only released as a ROS package right now, but it sounds like your team does your own packaging to use it on Windows, is that correct? |
Yes, we use it by installing through the (pure, non-catkin) CMake code in this repo. Thanks, what you just proposed is ideal. |
For the sake of precision: I actually noticed that we install the |
#80 todo:
|
As a side note, why is the ROS deb called |
Why is urdf_parser_py in this repository?
It contains ROS-specific code, e.g.
from_parameter_server
, which imports rospy when called:urdfdom/urdf_parser_py/src/urdf_parser_py/urdf.py
Line 443 in 59433bb
It is released in a separate ROS package (ros-indigo-urdf-parser-py).
It seems to me that it should either be moved into robot_model, OR
from_parameter_server
should be removed and it should be released as a python package (to be installed using pip, for example).@isucan, @eacousineau, etc. what are your thoughts?
The text was updated successfully, but these errors were encountered: