New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Occupancy grid node is missing #23

Open
routiful opened this Issue Nov 21, 2018 · 5 comments

Comments

Projects
None yet
2 participants
@routiful
Copy link

routiful commented Nov 21, 2018

I have developed cartographer example with TB3. But the master branch did not include the occupancy_grid_node. How can I get a /map topic to use this?

@clalancette

This comment has been minimized.

Copy link

clalancette commented Nov 27, 2018

When I did the initial port here, it was on an earlier version of cartographer that didn't need the separate occupancy_grid node. Since then, we've updated to a newer version of cartographer, but did not have time to update the code (we had to do this to get cartographer building on Ubuntu Bionic). If you'd like to contribute and do the port, that would be great; it is unlikely I'll have time to look into this anytime soon.

@routiful

This comment has been minimized.

Copy link
Author

routiful commented Dec 3, 2018

Okay, I will update the code soon. Thanks

@routiful

This comment has been minimized.

Copy link
Author

routiful commented Jan 6, 2019

I fetched the cartographer and cartographer_ros into release-1.0 branch and update ros2 api.
But i got stuck some problems. I opened issues in cartographer_ros repo.

googlecartographer#1151

Do you have any comments? @clalancette

The code was uploaded in ROBOTIS-GIT

https://github.com/ROBOTIS-GIT/cartographer
https://github.com/ROBOTIS-GIT/cartographer_ros

@clalancette

This comment has been minimized.

Copy link

clalancette commented Jan 17, 2019

The short answer is that we have not kept cartographer up-to-date with ROS 2 crystal. The last version we know for sure this port worked on is ROS 2 Ardent, and we haven't done updates on it since then. Probably the correct thing to do here is work with the upstream https://github.com/googlecartographer/cartographer_ros to do a maintained ROS 2 port of cartographer in a separate branch on that repo, using some of the work we did here as a reference.

@routiful

This comment has been minimized.

Copy link
Author

routiful commented Feb 1, 2019

@clalancette I've tested cartographer and cartographer_ros packages in ROS2 Crystal.
I opened PR(#25).
Please review this code and following tutorials.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment