Set logging format in tests to avoid drift when defaults change. #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuclearsandwich
force-pushed
the
nuclearsandwich/set-logging-format
branch
from
e3bda23
to
1268448
Compare
wjwwood
approved these changes
Dec 7, 2019
nuclearsandwich
force-pushed
the
nuclearsandwich/set-logging-format
branch
from
1268448
to
37804b0
Compare
Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>
nuclearsandwich
force-pushed
the
nuclearsandwich/set-logging-format
branch
from
37804b0
to
867fd29
Compare
dirk-thomas
approved these changes
Dec 7, 2019
The rosout failures are separate and still in my queue to squash and are shown above because I tested --packages-up-to rather than --packages-select. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ros2/rcutils#190 changed the default logging format which impacted these tests which compare the output against sample output.
As discussed in ros2/rcutils#190 (comment) setting the logging format in the test prevents it from being broken by future changes, so that's the approach I've taken.