Added README.md for dummy_robot_bringup. #574
Conversation
…ocumented expected behaviour. Verified instructions. Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
cardboardcode
changed the title
cardboardcode
changed the title
…ions for better cross-platform-compatibility. Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
cardboardcode
requested review from
adityapande-1995 and
mjeronimo
as code owners
Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
|
Testing for dependency cycles :
|
dummy_robot/dummy_robot_bringup/launch/dummy_robot_bringup.launch.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
adityapande-1995
left a comment
adityapande-1995
left a comment
There was a problem hiding this comment.
Could you please resolve the conflicts here @cardboardcode ? Looks good to me otherwise.
|
Rebased pull request branch to newly updated main rolling branch. Conflicts should now be resolved. |
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
|
Pulls: #574
|
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
@ahcorde thanks for taking the effort on this.
there are a few flake8 warnings to address.
https://ci.ros2.org/job/ci_linux-aarch64/19341/testReport/junit/(root)/projectroot/flake8/
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
|
|
https://github.com/Mergifyio backport kilted jazzy humble |
🟠 Pending
|
|
For what it is worth, I think it is a bad idea to backport this one because of the change in dependencies. At the very least, I would wait until it is out in Rolling for a bit before doing it. |
6 participants
Purpose of Pull Request
This pull request adds a
README.mdto dummy_robot_bringup as part of efforts to address the issue highlighted in #531.