r-simonelli/demos-lifecycle #750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
readme: clarify lifecycle node behavior and listener description Improves documentation for lifecycle nodes by explaining the distinction between primary and transition states, clarifying the behavior of callbacks, and refining the description of the lifecycle listener node. Signed-off-by: Ruggero Simonelli <ruggero.simonelli@protonmail.com>
ahcorde
requested changes
Nov 5, 2025
integrate suggestion Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: r-simonelli <ruggero.simonelli@protonmail.com>
integrate suggestion Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: r-simonelli <ruggero.simonelli@protonmail.com>
integrate suggestion Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: r-simonelli <ruggero.simonelli@protonmail.com>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: r-simonelli <ruggero.simonelli@protonmail.com>
integrate suggestion Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: r-simonelli <ruggero.simonelli@protonmail.com>
fujitatomoya
approved these changes
Nov 6, 2025
Collaborator
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm.
@ahcorde i will leave it to you.
| * inactive | ||
| * active | ||
| * shutdown | ||
| * finalized |
Collaborator
There was a problem hiding this comment.
Good point, this should be finalized 👍
ahcorde
approved these changes
Nov 6, 2025
Contributor
ahcorde
left a comment
ahcorde
left a comment
There was a problem hiding this comment.
This is just documentation, merging!
Contributor
|
https://github.com/Mergifyio backport kilted jazzy humble |
Contributor
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 6, 2025
Improves documentation for lifecycle nodes by explaining the distinction between primary and transition states, clarifying the behavior of callbacks, and refining the description of the lifecycle listener node. Signed-off-by: Ruggero Simonelli <ruggero.simonelli@protonmail.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit c16f934)
mergify bot
pushed a commit
that referenced
this pull request
Nov 6, 2025
Improves documentation for lifecycle nodes by explaining the distinction between primary and transition states, clarifying the behavior of callbacks, and refining the description of the lifecycle listener node. Signed-off-by: Ruggero Simonelli <ruggero.simonelli@protonmail.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit c16f934) # Conflicts: # lifecycle/README.rst
mergify bot
pushed a commit
that referenced
this pull request
Nov 6, 2025
Improves documentation for lifecycle nodes by explaining the distinction between primary and transition states, clarifying the behavior of callbacks, and refining the description of the lifecycle listener node. Signed-off-by: Ruggero Simonelli <ruggero.simonelli@protonmail.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit c16f934)
This was referenced Nov 6, 2025
ahcorde
added a commit
that referenced
this pull request
Nov 6, 2025
Improves documentation for lifecycle nodes by explaining the distinction between primary and transition states, clarifying the behavior of callbacks, and refining the description of the lifecycle listener node. (cherry picked from commit c16f934) Signed-off-by: Ruggero Simonelli <ruggero.simonelli@protonmail.com> Co-authored-by: r-simonelli <ruggero.simonelli@protonmail.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
ahcorde
added a commit
that referenced
this pull request
Nov 6, 2025
Improves documentation for lifecycle nodes by explaining the distinction between primary and transition states, clarifying the behavior of callbacks, and refining the description of the lifecycle listener node. (cherry picked from commit c16f934) Signed-off-by: Ruggero Simonelli <ruggero.simonelli@protonmail.com> Co-authored-by: r-simonelli <ruggero.simonelli@protonmail.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
ahcorde
added a commit
that referenced
this pull request
Nov 6, 2025
Improves documentation for lifecycle nodes by explaining the distinction between primary and transition states, clarifying the behavior of callbacks, and refining the description of the lifecycle listener node. Signed-off-by: Ruggero Simonelli <ruggero.simonelli@protonmail.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit c16f934)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readme: clarify lifecycle node behavior and listener description
Improves documentation for lifecycle nodes by explaining the distinction between primary and transition states, clarifying the behavior of callbacks, and refining the description of the lifecycle listener node.
Description
Fixes #749 (issue)
Is this user-facing behavior change?
Did you use Generative AI?
GPT-5 was used to improve wording.
Additional Information
The changes done should be self explanatory: I corrected small grammatical errors, added some structuring and detail where the text appeared to me to be not entirely clear.