New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for OpenCV v4.0 compatibility #306

Merged
merged 2 commits into from Jan 11, 2019

Conversation

Projects
None yet
4 participants
@jacobperron
Copy link
Member

jacobperron commented Jan 10, 2019

No description provided.

@jacobperron jacobperron self-assigned this Jan 10, 2019

@jacobperron jacobperron added in review and removed in progress labels Jan 10, 2019

@nuclearsandwich
Copy link
Member

nuclearsandwich left a comment

LGTM as long as it passes CI on Xenial, our current Windows builds, and MacOS with the latest OpenCV formula.

@wjwwood
Copy link
Member

wjwwood left a comment

lgtm, with one comment.

Thanks for looking into it.

@@ -124,7 +124,7 @@ cv::Mat & Burger::render_burger(size_t width, size_t height)
}
burger_buf = cv::Mat(height_i, width_i, CV_8UC3);
}
burger_buf = cvScalar(0, 0, 0);
burger_buf = cv::Scalar_<int>(0, 0, 0);

This comment has been minimized.

@wjwwood

wjwwood Jan 10, 2019

Member

Is there any reason you're using int specifically rather than double, i.e. cv::Scalar? I assume there is, but I'm just curious.

This comment has been minimized.

@jacobperron

jacobperron Jan 11, 2019

Author Member

Oops, no. I think this should just be cv::Scalar 😬

Fixed in 2877adb

@jacobperron

This comment has been minimized.

Copy link
Member Author

jacobperron commented Jan 11, 2019

Packages up to image_tools:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@jacobperron jacobperron merged commit 3dca291 into master Jan 11, 2019

1 check passed

Cpr__demos__ubuntu_bionic_amd64 Build finished.
Details

@jacobperron jacobperron deleted the cv4_compatibility branch Jan 11, 2019

@jacobperron jacobperron removed the in review label Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment