-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Demo to show the working of the incompatible_qos event callbacks. #416
Conversation
dae0e45
to
586626a
Compare
quality_of_service_demo/rclpy/quality_of_service_demo_py/incompatible_qos.py
Show resolved
Hide resolved
quality_of_service_demo/rclpy/quality_of_service_demo_py/incompatible_qos.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nits, but LGTM! 👍
115b22c
to
0bff4ec
Compare
Signed-off-by: Jaison Titus <jaisontj92@gmail.com>
Signed-off-by: Jaison Titus <jaisontj92@gmail.com>
Signed-off-by: Jaison Titus <jaisontj92@gmail.com>
Signed-off-by: Jaison Titus <jaisontj92@gmail.com>
Signed-off-by: Jaison Titus <jaisontj92@gmail.com>
Signed-off-by: Miaofei <miaofei@amazon.com>
0bff4ec
to
a178cd5
Compare
…istent Signed-off-by: Miaofei <miaofei@amazon.com>
d394d14
to
21be241
Compare
Signed-off-by: Miaofei <miaofei@amazon.com>
Signed-off-by: Miaofei <miaofei@amazon.com>
Signed-off-by: Miaofei <miaofei@amazon.com>
Signed-off-by: Miaofei <miaofei@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
quality_of_service_demo/rclpy/quality_of_service_demo_py/incompatible_qos.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Miaofei <miaofei@amazon.com>
@ros2/aws-oncall - please run this CI job |
@ivanpauno, there is a random buildfarm failure for the Linux-aarch64 run. Can we merge this pull request? |
Yes, I think it's safe to merge (considering that the last commit are just style changes and this PR has already passed CI before). |
Related to this feature request. The design and implementation details can also be found there.
Signed-off-by: Jaison Titus jaisontj92@gmail.com