Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update launch_ros Node action usage #431

Merged
merged 4 commits into from Mar 5, 2020
Merged

Conversation

jacobperron
Copy link
Member

@jacobperron jacobperron commented Feb 10, 2020

node_name and node_namespace parameters have been deprecated in ros2/launch_ros#122

node_name and node_namespace parameters have been deprecated in ros2/launch_ros#122

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron self-assigned this Feb 10, 2020
@jacobperron jacobperron added the enhancement New feature or request label Feb 10, 2020
jacobperron added 3 commits Feb 12, 2020
The parameter 'node_name' is deprecated, replaced by 'name'.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Composable description parameter names haven't changed.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
hidmic
hidmic approved these changes Feb 17, 2020
Copy link
Contributor

@hidmic hidmic left a comment

LGTM too

@jacobperron
Copy link
Member Author

jacobperron commented Mar 5, 2020

CI is here: ros2/launch_ros#122 (comment)

@jacobperron jacobperron merged commit 948b4f4 into master Mar 5, 2020
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the jacob/rename_node_name_attr branch Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants