-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Demo for pre and post set parameter callback support #565
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done a first pass; thanks for adding a demo for the new feature!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks alright to me, but I think the files need to be checked for formatting. You can try running ament_cpplint
or ament_cppcheck
on your machine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
@adityapande-1995 @jacobperron should we merge this now, since the rclpy and rclcpp PR's have been merged already. |
@deepanshubansal01 lgtm, can you address the conflicts? |
Will do. |
demo_nodes_py/demo_nodes_py/parameters/set_parameters_callback.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a couple of stylistic points to consider.
demo_nodes_py/demo_nodes_py/parameters/set_parameters_callback.py
Outdated
Show resolved
Hide resolved
Seems like it's good to go, should I squash and merge now? |
We still need approval and to run CI on it. I'll take another look, though I may not get back to it today. |
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
b94bc55
to
7078cbf
Compare
Seems like CI is passing now. Can I squash merge now or wait for more pending reviewers. Thanks! |
This reverts commit 25f6176.
* local parameter callback support Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
* local parameter callback support Signed-off-by: deepanshu <deepanshubansal01@gmail.com> Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
Related to ros2/rclcpp#1947 and ros2/rclpy#966
Signed-off-by: deepanshu deepanshubansal01@gmail.com