Override handle_serialized_message. #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should allow it to build against rolling again. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
jacobperron
reviewed
May 19, 2021
|
Thanks for this. I was confused why this was failing on Rolling and didn't take the time to investigate. |
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
I've noticed a couple times that the |
|
@ros-pull-request-builder retest this please |
jacobperron
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow it to build against rolling again.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
This has been failing in Rolling for a couple of weeks now: https://build.ros2.org/view/Rbin_uF64/job/Rbin_uF64__domain_bridge__ubuntu_focal_amd64__binary/
Note that this change is not backwards-compatible with Galactic, so we'll have to branch off for Galactic to take this fix.