Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed examples_rclcpp_minimal_action_client sequence type #268

Merged
merged 1 commit into from
May 12, 2020
Merged

Fixed examples_rclcpp_minimal_action_client sequence type #268

merged 1 commit into from
May 12, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented May 12, 2020

Fibonacci action interface use int32 for the sequence. However in the code this is printed as int64.

Signed-off-by: ahcorde ahcorde@gmail.com

@ahcorde
Fixed action_client sequence type
4162190 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde added the bug Something isn't working label May 12, 2020
@ahcorde ahcorde requested a review from jacobperron May 12, 2020 12:47
@ahcorde ahcorde self-assigned this May 12, 2020
clalancette
clalancette approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me with green CI.

@ahcorde ahcorde changed the title Fixed examples_rclcpp_minimal_action_server sequence type Fixed examples_rclcpp_minimal_action_client sequence type May 12, 2020
@ahcorde
Copy link
Contributor Author

ahcorde commented May 12, 2020

Compiling up-to examples_rclcpp_minimal_action_client. There is no test for this package:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit d51db0c into master May 12, 2020
@delete-merged-branch delete-merged-branch bot deleted the ahcorde/fix/action_client_sequence_type branch May 12, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@jacobperron jacobperron Awaiting requested review from jacobperron

Assignees

@ahcorde ahcorde

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahcorde @clalancette