Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate class loader headers #204

Merged
merged 2 commits into from Feb 15, 2018

Conversation

Projects
None yet
2 participants
@mikaelarguedas
Copy link
Contributor

commented Feb 9, 2018

related to ros/class_loader#80

@@ -7,7 +7,7 @@ if(NOT CMAKE_CXX_STANDARD)
endif()

if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
add_compile_options(-Wall -Wextra)
add_compile_options(-Wall -Wextra -Wpedantic)

This comment has been minimized.

Copy link
@mikaelarguedas

mikaelarguedas Feb 12, 2018

Author Contributor

This is actually throwing warnings on OSX because of ros/console_bridge#55

This comment has been minimized.

Copy link
@mikaelarguedas

mikaelarguedas Feb 15, 2018

Author Contributor

Worked around the clang console_bridge warnings in ros/class_loader@161568a

@mikaelarguedas mikaelarguedas merged commit fcbf232 into master Feb 15, 2018

@mikaelarguedas mikaelarguedas deleted the deprecate_class_loader_headers branch Feb 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.