Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear callbacks_to_remove variable after removing #303

Merged
merged 1 commit into from Aug 10, 2020

Conversation

mdtoom
Copy link
Contributor

@mdtoom mdtoom commented Aug 10, 2020

Prevents a ValueError when calling _call_new_data_callbacks after a callback has been removed.

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I'll run CI on this next.

@clalancette
Copy link
Contributor

clalancette commented Aug 10, 2020

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@clalancette
Copy link
Contributor

Thanks for the contribution! Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants