Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using ament_target_dependencies where possible #98

Merged
merged 5 commits into from Mar 19, 2019

Conversation

Projects
None yet
3 participants
@ivanpauno
Copy link

commented Mar 14, 2019

Partially targets ros2/ros2#658

Show resolved Hide resolved tf2_eigen/CMakeLists.txt Outdated

@ivanpauno ivanpauno changed the title Fixed ros2#658 Using ament_target_dependencies where possible Mar 15, 2019

Show resolved Hide resolved tf2_eigen/CMakeLists.txt Outdated

ivanpauno and others added some commits Mar 15, 2019

Deleted custom variable 'Eigen_INCLUDE_DIR'
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>

Nope

@@ -15,8 +15,6 @@ find_package(tf2 REQUIRED)
find_package(tf2_ros REQUIRED)

find_package(Eigen3 REQUIRED)
set(Eigen_INCLUDE_DIR "${EIGEN3_INCLUDE_DIR}")
message(STATUS "Using Eigen3 include dirs: ${Eigen_INCLUDE_DIR}")

This comment has been minimized.

Copy link
@dirk-thomas

dirk-thomas Mar 15, 2019

Member

The message should still be kept.

Added Eigen message again
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>

@ivanpauno ivanpauno self-assigned this Mar 18, 2019

@ivanpauno ivanpauno added in review and removed in progress labels Mar 18, 2019

@ivanpauno

This comment has been minimized.

Copy link
Author

commented Mar 19, 2019

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

All failures are unrelated, so I'm merging

@ivanpauno ivanpauno merged commit 7d96bce into ros2:ros2 Mar 19, 2019

@ivanpauno ivanpauno removed the in review label Mar 19, 2019

nuclearsandwich added a commit to ros/rosdistro that referenced this pull request Apr 14, 2019

geometry2: 0.11.0-1 in 'dashing/distribution.yaml' [bloom] (#20931)
Increasing version of package(s) in repository `geometry2` to `0.11.0-1`:

- upstream repository: https://github.com/ros2/geometry2.git
- release repository: https://github.com/ros2-gbp/geometry2-release.git
- distro file: `dashing/distribution.yaml`
- bloom version: `0.8.0`
- previous version for package: `null`

## tf2

- No changes

## tf2_eigen

```
* Updated to use ament_target_dependencies where possible. (#98 <ros2/geometry2#98>)
* Contributors: ivanpauno
```

## tf2_geometry_msgs

```
* Updated to use ament_target_dependencies where possible. (#98 <ros2/geometry2#98>)
```

## tf2_msgs

- No changes

## tf2_ros

```
* Updated to use node inteface pointers in the MessageFilter class. (#96 <ros2/geometry2#96>)
* Updated message_filter.h. (#91 <ros2/geometry2#91>)
* Contributors: Michael Jeronimo, Sagnik Basu
```

## tf2_sensor_msgs

- No changes

vmayoral added a commit to AcutronicRobotics/geometry2 that referenced this pull request Apr 26, 2019

Using ament_target_dependencies where possible (ros2#98)
* Fixed ros2#658

Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>

* Modified Eigen include directory again

Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>

* Deleted custom variable 'Eigen_INCLUDE_DIR'

Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>

* revert unrelated whitespace change

Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>

* Added Eigen message again

Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>

andre-rosa added a commit to andre-rosa/rosdistro that referenced this pull request May 3, 2019

geometry2: 0.11.0-1 in 'dashing/distribution.yaml' [bloom] (ros#20931)
Increasing version of package(s) in repository `geometry2` to `0.11.0-1`:

- upstream repository: https://github.com/ros2/geometry2.git
- release repository: https://github.com/ros2-gbp/geometry2-release.git
- distro file: `dashing/distribution.yaml`
- bloom version: `0.8.0`
- previous version for package: `null`

## tf2

- No changes

## tf2_eigen

```
* Updated to use ament_target_dependencies where possible. (ros#98 <ros2/geometry2#98>)
* Contributors: ivanpauno
```

## tf2_geometry_msgs

```
* Updated to use ament_target_dependencies where possible. (ros#98 <ros2/geometry2#98>)
```

## tf2_msgs

- No changes

## tf2_ros

```
* Updated to use node inteface pointers in the MessageFilter class. (ros#96 <ros2/geometry2#96>)
* Updated message_filter.h. (ros#91 <ros2/geometry2#91>)
* Contributors: Michael Jeronimo, Sagnik Basu
```

## tf2_sensor_msgs

- No changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.