Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unnecessary loading of 'launch.frontend.interpolate_substitution_method' entry point that was never used #434

Merged
merged 1 commit into from Jun 26, 2020

Conversation

ivanpauno
Copy link
Member

I think the original idea was to have a way of overloading the default substitution interpolation method (i.e. use sth different than $() notation), but custom parsers can already override parse_substitution method:

def parse_substitution(self, value: Text) -> SomeSubstitutionsType:

def load_parser_implementations(cls):
"""Load all the available frontend entities."""
if cls.frontend_parsers is None:
cls.frontend_parsers = {
entry_point.name: entry_point.load()
for entry_point in importlib_metadata.entry_points().get(
'launch.frontend.parser', [])
}

I think I forgot deleting the loading of this entry points of the original code, because it doesn't make sense.

…on_method' entry point that was never used

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added the in review Waiting for review (Kanban column) label Jun 25, 2020
@ivanpauno ivanpauno requested a review from hidmic June 25, 2020 20:48
@ivanpauno ivanpauno self-assigned this Jun 25, 2020
@ivanpauno
Copy link
Member Author

Rolling PR checker is passing.
This is just removing dead code, so I will proceed to merge without running multi-platform CI.

@ivanpauno ivanpauno merged commit 0fb446e into master Jun 26, 2020
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/delete-unnecessary-entry-point-load branch June 26, 2020 21:12
@ivanpauno ivanpauno added this to Proposed in Foxy Patch Release 1 via automation Jun 26, 2020
@ivanpauno ivanpauno moved this from Proposed to Needs backport in Foxy Patch Release 1 Jun 26, 2020
@ivanpauno ivanpauno added this to Needs Backport in Eloquent Patch Release 2 Jun 26, 2020
@jacobperron jacobperron added this to Proposed in Foxy Patch Release 2 via automation Jul 10, 2020
@jacobperron jacobperron removed this from Needs backport in Foxy Patch Release 1 Jul 10, 2020
@jacobperron jacobperron moved this from Proposed to Needs backport in Foxy Patch Release 2 Jul 10, 2020
@jacobperron jacobperron removed this from Needs backport in Foxy Patch Release 2 Aug 7, 2020
@jacobperron jacobperron added this to Proposed in Foxy Patch Release 3 via automation Aug 7, 2020
@jacobperron jacobperron moved this from Proposed to Needs backport in Foxy Patch Release 3 Aug 7, 2020
jacobperron pushed a commit that referenced this pull request Oct 2, 2020
…on_method' entry point that was never used (#434)

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@jacobperron jacobperron removed this from Needs backport in Foxy Patch Release 3 Oct 2, 2020
jacobperron pushed a commit that referenced this pull request Oct 2, 2020
…on_method' entry point that was never used (#434)

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@jacobperron jacobperron removed this from Needs Backport in Eloquent Patch Release 2 Oct 2, 2020
jacobperron added a commit that referenced this pull request Oct 2, 2020
…on_method' entry point that was never used (#434) (#463)

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>

Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
jacobperron added a commit that referenced this pull request Oct 2, 2020
…on_method' entry point that was never used (#434) (#464)

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>

Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in review Waiting for review (Kanban column)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants