Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move sensor_msgs to be a test dependency. #17

Merged
merged 2 commits into from Nov 21, 2018
Merged

Conversation

@tfoote
Copy link
Contributor

tfoote commented Nov 21, 2018

It's only used in the tests. Otherwise it would need to be exported for osx linking.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status
Copy link

clalancette left a comment

Agreed that this looks like a test-only dependency. This looks good to me, so assuming this fixes the problems on macOS in the CI run on ros2/geometry2#81 (comment), let's merge it :).

…Otherwise it would need to be exported for osx linking.
@tfoote tfoote force-pushed the cleanup_sensor_msgs_dependency branch from f7239d6 to 2685bf5 Nov 21, 2018
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@tfoote tfoote merged commit ecc036f into master Nov 21, 2018
@tfoote tfoote deleted the cleanup_sensor_msgs_dependency branch Nov 21, 2018
@tfoote tfoote removed the in review label Nov 21, 2018
@tfoote tfoote restored the cleanup_sensor_msgs_dependency branch Nov 21, 2018
@tfoote tfoote deleted the cleanup_sensor_msgs_dependency branch Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.