Use specific msvc cmake generator. #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI:
|
|
CI result for MacOS is throwing this warning: Policy CMP0042 is not set: MACOSX_RPATH is enabled by default. Run "cmake. Have any idea how to solve this? I won't block this PR for that warning, can be fixed with Windows CI error pending to be resolved. |
|
Let's give it a shot now. |
|
Argh, this is giving me a hard time. |
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
hidmic
force-pushed
the
hidmic/use-msvc-generator
branch
from
2ca69a3
to
3dac1fd
Compare
|
All tier 1 CI Green, feel free to merge! This will unblock ros2/ros2#985 |
Blast545
approved these changes
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precisely what the title says.