Suppress memory tools warning if tests will be skipped #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd prefer to inspect the test itself to see if it will be skipped individually, but this warning is implemented in a common location so that it is printed once, instead of once for each defined test. Looking at the source variable, `AMENT_RUN_PERFORMANCE_TESTS`, should give us the same behavior. Signed-off-by: Scott K Logan <logans@cottsay.net>
Signed-off-by: Scott K Logan <logans@cottsay.net>
cottsay
force-pushed
the
suppress_warning
branch
from
cb17cc3
to
d817562
Compare
brawner
reviewed
Sep 9, 2020
brawner
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd prefer to inspect the test itself to see if it will be skipped individually, but this warning is implemented in a common location so that it is printed once, instead of once for each defined test. Looking at the source variable,
AMENT_RUN_PERFORMANCE_TESTS, should give us the same behavior.Coupled to ament/ament_cmake#278.