__ns remapping not working when specified for a particular node

[dhood]

This works:

]$ ros2 run demo_nodes_cpp talker talker:__node:=new_node_name
[INFO] [new_node_name]: Publishing: 'Hello World: 1'
^Csignal_handler(2)

As does this:

$ ros2 run demo_nodes_cpp talker __ns:=/new_ns
[INFO] [new_ns.talker]: Publishing: 'Hello World: 1'
[INFO] [new_ns.talker]: Publishing: 'Hello World: 2'

But this doesn't seem to:

$ ros2 run demo_nodes_cpp talker talker:__ns:=/new_ns
[INFO] [talker]: Publishing: 'Hello World: 1'
[INFO] [talker]: Publishing: 'Hello World: 2'
^Csignal_handler(2)

There's a chance this combination isn't expected to work, but I think it might be.

[wjwwood]

I would also consider that to be a bug.

[sloretz]

definitely a bug

There's a unit test for rcl_remap_node_namespace()

rcl/rcl/test/rcl/test_remap.cpp

Lines 55 to 86 in c9fe312

	TEST_F(CLASSNAME(TestRemapFixture, RMW_IMPLEMENTATION), nodename_prefix_namespace_remap) {
	rcl_ret_t ret;
	rcl_arguments_t global_arguments;
	SCOPE_ARGS(
	global_arguments,
	"process_name", "Node1:__ns:=/foo/bar", "Node2:__ns:=/this_one", "Node3:__ns:=/bar/foo");
	{
	char * output = NULL;
	ret = rcl_remap_node_namespace(
	NULL, &global_arguments, "Node1", rcl_get_default_allocator(), &output);
	EXPECT_EQ(RCL_RET_OK, ret);
	EXPECT_STREQ("/foo/bar", output);
	rcl_get_default_allocator().deallocate(output, rcl_get_default_allocator().state);
	}
	{
	char * output = NULL;
	ret = rcl_remap_node_namespace(
	NULL, &global_arguments, "Node2", rcl_get_default_allocator(), &output);
	EXPECT_EQ(RCL_RET_OK, ret);
	EXPECT_STREQ("/this_one", output);
	rcl_get_default_allocator().deallocate(output, rcl_get_default_allocator().state);
	}
	{
	char * output = NULL;
	ret = rcl_remap_node_namespace(
	NULL, &global_arguments, "Node3", rcl_get_default_allocator(), &output);
	EXPECT_EQ(RCL_RET_OK, ret);
	EXPECT_STREQ("/bar/foo", output);
	rcl_get_default_allocator().deallocate(output, rcl_get_default_allocator().state);
	}
	}

but there's not an integration test for it https://github.com/ros2/rcl/blob/master/rcl/test/rcl/test_remap_integration.cpp

[dhood]

Yeah I have one prepared that fails, will open a pr for the test

…

On Tue., 19 Jun. 2018, 08:18 Shane Loretz, ***@***.***> wrote: definitely a bug There's a unit test for rcl_remap_node_namespace() https://github.com/ros2/rcl/blob/c9fe312674f8c5a2c5b40b6208c830f4ca8c40ff/rcl/test/rcl/test_remap.cpp#L55-L86 but there's not an integration test for it https://github.com/ros2/rcl/blob/master/rcl/test/rcl/test_remap_integration.cpp — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#262 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFW5nGYfiMnox_c-dQO-DkhGzF5fgdM5ks5t-RZjgaJpZM4Us2TX> .

[kev-the-dev]

Fixed and tested in #263