From 39b0bdc07bbf413c67d6961fbdc523931fd62fa6 Mon Sep 17 00:00:00 2001 From: Kaven Yau Date: Mon, 26 Apr 2021 21:30:42 +0800 Subject: [PATCH] fix TestServerGoalHandle.cancel unit test Signed-off-by: Kaven Yau --- rclcpp_action/test/test_server_goal_handle.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rclcpp_action/test/test_server_goal_handle.cpp b/rclcpp_action/test/test_server_goal_handle.cpp index cd56ba4a8f..a38ebe7af1 100644 --- a/rclcpp_action/test/test_server_goal_handle.cpp +++ b/rclcpp_action/test/test_server_goal_handle.cpp @@ -44,7 +44,7 @@ class FibonacciServerGoalHandle bool try_cancel() {return try_canceling();} - void cancel_goal() {_cancel_goal();} + bool cancel_goal() {return _cancel_goal();} }; class TestServerGoalHandle : public ::testing::Test @@ -110,7 +110,7 @@ TEST_F(TestServerGoalHandle, cancel) { auto mock_is_cancelable = mocking_utils::patch_and_return( "lib:rclcpp_action", rcl_action_goal_handle_is_cancelable, true); EXPECT_FALSE(handle_->try_cancel()); - EXPECT_THROW(handle_->cancel_goal(), rclcpp::exceptions::RCLError); + EXPECT_FALSE(handle_->cancel_goal()); test_msgs::action::Fibonacci::Result::SharedPtr result = std::make_shared();