From f02e2c0a2a8f2b2f9726e21e66e315f19e12016d Mon Sep 17 00:00:00 2001 From: Scott K Logan Date: Thu, 13 May 2021 10:42:09 -0700 Subject: [PATCH] Bump the benchmark timeout for benchmark_action_client Pausing and resuming the measurement inside the timing loop can cause the initial run duration calculation to underestimate how long the benchmark is taking to run, which results in the recorded run taking a lot longer than it should. This is a known issue in libbenchmark. This test is affected by that behavior, and typically takes a bit longer than the others. The easiest thing to do right now is to just bump the timeout. My tests show that 180 seconds is typically sufficient for this test, so 240 should be a safe point to conclude that the test is malfunctioning. Signed-off-by: Scott K Logan --- rclcpp_action/test/benchmark/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rclcpp_action/test/benchmark/CMakeLists.txt b/rclcpp_action/test/benchmark/CMakeLists.txt index b9aabf2375..dc87c553af 100644 --- a/rclcpp_action/test/benchmark/CMakeLists.txt +++ b/rclcpp_action/test/benchmark/CMakeLists.txt @@ -7,7 +7,7 @@ find_package(performance_test_fixture REQUIRED) add_performance_test( benchmark_action_client benchmark_action_client.cpp - TIMEOUT 120) + TIMEOUT 240) if(TARGET benchmark_action_client) target_link_libraries(benchmark_action_client ${PROJECT_NAME}) ament_target_dependencies(benchmark_action_client rclcpp test_msgs)