Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rosidl dependencies #507

Merged
merged 2 commits into from Jul 5, 2018

Conversation

Projects
None yet
2 participants
@mikaelarguedas
Copy link
Contributor

commented Jul 3, 2018

This package does not generate any message so it doesnt need to depend on the generators, instead it should link against the libraries that provide the symbols it uses (in this case rosidl_typesupport_cpp)

Connects to ros2/demos#264

@mikaelarguedas

This comment has been minimized.

Copy link
Contributor Author

commented Jul 3, 2018

CI for this at ros2/demos#264 (comment)

@mikaelarguedas mikaelarguedas added in review and removed in progress labels Jul 3, 2018

@mikaelarguedas mikaelarguedas self-assigned this Jul 4, 2018

@mikaelarguedas mikaelarguedas merged commit 4507d7a into master Jul 5, 2018

@mikaelarguedas mikaelarguedas deleted the remove_unused_deps branch Jul 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.