From 9fa7642863c24e154c127cfc1d904175a08466e9 Mon Sep 17 00:00:00 2001 From: Karsten Knese Date: Fri, 17 Aug 2018 09:51:50 -0700 Subject: [PATCH] log error message instead of throwing exception in destructor --- rclcpp/include/rclcpp/message_memory_strategy.hpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/rclcpp/include/rclcpp/message_memory_strategy.hpp b/rclcpp/include/rclcpp/message_memory_strategy.hpp index c4de703564..fd92500efc 100644 --- a/rclcpp/include/rclcpp/message_memory_strategy.hpp +++ b/rclcpp/include/rclcpp/message_memory_strategy.hpp @@ -25,6 +25,8 @@ #include "rclcpp/macros.hpp" #include "rclcpp/visibility_control.hpp" +#include "rcutils/logging_macros.h" + #include "rmw/serialized_message.h" namespace rclcpp @@ -96,7 +98,9 @@ class MessageMemoryStrategy auto ret = rmw_serialized_message_fini(msg); delete msg; if (ret != RCL_RET_OK) { - rclcpp::exceptions::throw_from_rcl_error(ret, "leaking memory"); + RCUTILS_LOG_ERROR_NAMED( + "rclcpp", + "failed to destroy serialized message: %s", rcl_get_error_string_safe()); } });