From 5418ff90975a5bdc7d25af1bd05bd90803d038e4 Mon Sep 17 00:00:00 2001 From: Yutaka Kondo Date: Sun, 30 Dec 2018 11:05:24 +0900 Subject: [PATCH] replace 'auto' to 'const auto &' Signed-off-by: Yutaka Kondo --- rclcpp/src/rclcpp/node_interfaces/node_parameters.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/rclcpp/src/rclcpp/node_interfaces/node_parameters.cpp b/rclcpp/src/rclcpp/node_interfaces/node_parameters.cpp index 37588b2b31..8c4d14b94c 100644 --- a/rclcpp/src/rclcpp/node_interfaces/node_parameters.cpp +++ b/rclcpp/src/rclcpp/node_interfaces/node_parameters.cpp @@ -177,7 +177,7 @@ NodeParameters::set_parameters( const std::vector & parameters) { std::vector results; - for (auto p : parameters) { + for (const auto & p : parameters) { auto result = set_parameters_atomically({{p}}); results.push_back(result); } @@ -206,7 +206,7 @@ NodeParameters::set_parameters_atomically( return result; } - for (auto p : parameters) { + for (const auto & p : parameters) { if (p.get_type() == rclcpp::ParameterType::PARAMETER_NOT_SET) { if (parameters_.find(p.get_name()) != parameters_.end()) { // case: parameter was set before, and input is "NOT_SET" @@ -229,7 +229,7 @@ NodeParameters::set_parameters_atomically( tmp_map.insert(parameters_.begin(), parameters_.end()); // remove explicitly deleted parameters - for (auto p : parameters) { + for (const auto & p : parameters) { if (p.get_type() == rclcpp::ParameterType::PARAMETER_NOT_SET) { tmp_map.erase(p.get_name()); }