Future invokes done callbacks when done #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an executor is set, the future will try to schedule done callback on it. If no executor is set, the future will invoke the done callbacks directly. Signed-off-by: Shane Loretz<sloretz@openrobotics.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
|
CI (Testing all packages above rclpy)
|
|
CI looks ok, just flake8 warnings already fixed by ros2/ros2cli#399 and ros2/launch_ros#94 |
mjcarroll
approved these changes
Nov 18, 2019
jaisontj
pushed a commit
to aws-ros-dev/rclpy
that referenced
this pull request
Nov 19, 2019
If an executor is set, the future will try to schedule done callback on it. If no executor is set, the future will invoke the done callbacks directly. Signed-off-by: Shane Loretz<sloretz@openrobotics.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
nuclearsandwich
pushed a commit
that referenced
this pull request
Dec 6, 2019
If an executor is set, the future will try to schedule done callback on it. If no executor is set, the future will invoke the done callbacks directly. Signed-off-by: Shane Loretz<sloretz@openrobotics.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
nuclearsandwich
pushed a commit
that referenced
this pull request
Dec 6, 2019
If an executor is set, the future will try to schedule done callback on it. If no executor is set, the future will invoke the done callbacks directly. Signed-off-by: Shane Loretz<sloretz@openrobotics.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>
suab321321
pushed a commit
to suab321321/rclpy
that referenced
this pull request
Jan 31, 2020
If an executor is set, the future will try to schedule done callback on it. If no executor is set, the future will invoke the done callbacks directly. Signed-off-by: Shane Loretz<sloretz@openrobotics.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Signed-off-by: AbhinavSingh <singhabhinav9051571833@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #460
If an executor is set, the future try to schedule done callback on it. If no executor is set, the future will invoke the done callbacks directly. This is sort of a hybrid of how
asyncioandconcurrent.futureshandle this situation.This should be backported to Dashing.