Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timer related tests experience more jitter on windows #513

Open
brawner opened this issue Feb 22, 2020 · 3 comments
Open

Timer related tests experience more jitter on windows #513

brawner opened this issue Feb 22, 2020 · 3 comments
Assignees

Comments

@brawner
Copy link
Contributor

@brawner brawner commented Feb 22, 2020

test_rate.py fails periodically on ci_windows-container builds, but I think it is also an issue on ci_windows as well. The jitter in the Rate period is about 0.01 seconds, which also happens to be the max_jitter criteria. I printed out the measurements so you can get idea of the ranges for the different build systems.

The strange thing that maybe someone can illuminate is why the period measurements are very precisely 0.094s and 0.011s.

I don't think the actual issue is in rclpy. If someone can help shed light on this, I can keep trying to dig into this issue.

https://ci.ros2.org/job/ci_linux/9412/testReport/rclpy.src.ros2.rclpy.rclpy.test.test_rate/TestRate/test_rate_valid_period/
https://ci.ros2.org/job/ci_windows/9327/testReport/rclpy.src.ros2.rclpy.rclpy.test.test_rate/TestRate/test_rate_valid_period/
https://ci.ros2.org/job/ci_windows-container/184/testReport/junit/(root)/projectroot/test_rate/
https://ci.ros2.org/job/ci_linux-aarch64/5090/testReport/rclpy.src.ros2.rclpy.rclpy.test.test_rate/TestRate/test_rate_valid_period/
https://ci.ros2.org/job/ci_osx/7699/testReport/junit/rclpy.src.ros2.rclpy.rclpy.test.test_rate/TestRate/test_rate_valid_period/

More examples:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status
  • Windows-container Build Status

Possible related issue:
#267

@brawner brawner changed the title test_rate.py experiences more jitter on windows Timer related tests experience more jitter on windows Feb 24, 2020
@brawner

This comment has been minimized.

Copy link
Contributor Author

@brawner brawner commented Feb 24, 2020

Updating to reflect that this also affects the test_timer.py 100Hz tests. Windows can handle 10Hz, but gets flakey on 100Hz.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status
  • Windows-container Build Status
@ros-discourse

This comment has been minimized.

Copy link

@ros-discourse ros-discourse commented Mar 16, 2020

This issue has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/windows-ci-builds-are-now-officially-containerized-and-virtualized-on-ci-ros2-org/13099/4

@ros-discourse

This comment has been minimized.

Copy link

@ros-discourse ros-discourse commented Mar 20, 2020

This issue has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2020-03-18/13313/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.