Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macro semicolons #120

Merged
merged 3 commits into from Oct 5, 2018

Conversation

Projects
None yet
2 participants
@clalancette
Copy link
Contributor

commented Oct 5, 2018

Connects to #113

clalancette added some commits Sep 5, 2018

Add semicolons to all RCLCPP and RCUTILS macros.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Fix uncrustify.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@mjcarroll

This comment has been minimized.

Copy link
Contributor

commented Oct 5, 2018

Maybe just a quick note on why the do...while(0) is necessary?

@clalancette

This comment has been minimized.

Copy link
Contributor Author

commented Oct 5, 2018

Maybe just a quick note on why the do...while(0) is necessary?

Good idea, will add.

Add in comment on why do { ... } while (0) in macros.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

@clalancette clalancette merged commit ba1fe74 into master Oct 5, 2018

@clalancette clalancette deleted the add-macro-semicolons branch Oct 5, 2018

@clalancette clalancette removed the in review label Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.