Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move stdatomic helper to rcutils #126

Merged
merged 3 commits into from Nov 8, 2018

Conversation

Projects
None yet
2 participants
@wjwwood
Copy link
Member

commented Nov 8, 2018

We've discussed doing this a few times, but my most recent work required that I make this helper interface public in rcl (previously it was only used in the source part of rcl and the headers were not installed), so I thought I might as well move it to rcutils while making it public at the same time.

wjwwood added some commits Nov 8, 2018

initial migration of stdatomic_helper.h to rcutils from rcl
Signed-off-by: William Woodall <william@osrfoundation.org>
refactor namespaces after moving files
Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood

This comment has been minimized.

Copy link
Member Author

commented Nov 8, 2018

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status
@jacobperron
Copy link
Member

left a comment

LGTM

address line length linter warning
Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood

This comment has been minimized.

Copy link
Member Author

commented Nov 8, 2018

CI after fixing the line length 💀:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@wjwwood wjwwood merged commit 3963a3e into master Nov 8, 2018

@wjwwood wjwwood deleted the move_stdatomic_helper_to_rcutils branch Nov 8, 2018

@wjwwood wjwwood removed the in review label Nov 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.