Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename result variable for clarity. #157

merged 1 commit into from May 6, 2019


None yet
3 participants
Copy link

commented May 6, 2019

This is a followup to #155. As mentioned by @clalancette basename_copy is also a candidate as it is what basec is intended to abbreviate.

@nuclearsandwich nuclearsandwich requested review from wjwwood and clalancette May 6, 2019

@nuclearsandwich nuclearsandwich self-assigned this May 6, 2019

Rename result variable for clarity.
Signed-off-by: Steven! Ragnarök <>

@nuclearsandwich nuclearsandwich force-pushed the logging-followup branch from 5383fde to be31210 May 6, 2019


wjwwood approved these changes May 6, 2019


This comment has been minimized.

Copy link
Member Author

commented May 6, 2019

CI for this change was run in ros2/rcl_logging#12 (comment)

Though there are failures in the run, they're all due to the fact that linters are now being run for the rcl_logging packages so this small internal change broke nothing (as one would hope).

@nuclearsandwich nuclearsandwich merged commit d3e2762 into master May 6, 2019

1 of 2 checks passed

Dpr__rcutils__ubuntu_bionic_amd64 Build finished.

@delete-merged-branch delete-merged-branch bot deleted the logging-followup branch May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.