Match alloc and free calls #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm, I guess was |
|
The |
|
@wjwwood, if you like this change, can you merge it? (I don't have commit permissions on this repo.) |
mauropasse
pushed a commit
to mauropasse/rmw_fastrtps
that referenced
this pull request
Dec 1, 2020
Rename set_events_executor_callback->set_listener_callback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test result:
http://ci.ros2.org/view/nightly/job/nightly_linux/143/testReport/%28root%29/test_services_cpp__rmw_fastrtps_cpp/test_services_cpp/
shows a service client crashing with a SIGABRT (-6). valgrind identified mismatched allocation and destruction calls. Here I'm matching them up. With this change, valgrind gives a zero-error report on the service client (there still seem to be situations in which the test can hang instead of passing, but that's a different matter).