Refactor functions cpp #135
Conversation
|
|
||
| extern "C" | ||
| { | ||
| extern const char * const ros_topic_prefix; |
There was a problem hiding this comment.
If you're in an extern group, do you need to extern the internal definitions? Not sure if this was there previously, but I think the internal extern's should be removed.
There was a problem hiding this comment.
aren't these two different things? The extern "C" is responsible for symbol mangling and the extern const.. is for telling that the definition of this variable is happening in another file?
|
Linux: |
Karsten1987
added
in review
|
The patch looks good to me. Since the PR should be merged without squashing at the end can you please squash some of the later commits wherever it makes sense (the first two / three commits must stay separated though). |
Karsten1987
force-pushed
the
refactor_functions_cpp
branch
from
3c60f11
to
de764b9
Compare
Correctly compile inline functions
function style include algorithm for demangle.cpp fix typo delete unused backup file
|
Currently the first commit adds a |
dirk-thomas
force-pushed
the
refactor_functions_cpp
branch
from
de764b9
to
5920279
Compare
|
connects to #131
summary of commits:
1.) split
functions.cppinto multiple files (git blame on each file still shows correct history)2.) cleanup these files with only their respective necessary parts
3.) change
CMakeLists.txtto compile all files4.) change
TypeSupport_impl.hppto correctly compile template specifications as inline5.) a little bit of style for functions
I'll leave it as it is for now, hoping on getting this PR merged quickly. Further improvements can thus be done in separate PRs.