remove unneeded line from CMakeLists

[rotu]

I don't think we need to tweak the link_directories to get this Poco to link properly

[dirk-thomas]

This builds on top of #67.

As mentioned in that ticket please consider to provide the additional information so that we can be certain that the link_directories(${Poco_LIBRARY_DIR}) call can be safely removed.

[rotu]

What additional information is needed? Correctly building on target platforms should prove that this PR is correct. Please run CI to confirm.

[dirk-thomas]

What additional information is needed?

It helps to understand why it was used and necessary in the past, what has changed in the meantime, and confirms it can be safely removed now.

Correctly building on target platforms should prove that this PR is correct. Please run CI to confirm.

Passing builds only show that it works on the exact configurations used but doesn't provide us with any understanding.

• Linux
• Linux-aarch64
• macOS
• Windows

[rotu]

You made that change, so you tell me. It looks to me like it was never necessary.

52a46ba#diff-0c408aa74d7519e29ea65afd30874fcf

#17

Passing builds only show that it works on the exact configurations used but doesn't provide us with any understanding.

True but (1) that applies to everything (2) CI gives the best assurance that this works across supported build configurations.

[dirk-thomas]

True but (1) that applies to everything (2) CI gives the best assurance that this works across supported build configurations.

I like to understand why things work / don't work and what has changed.

I am pretty sure for earlier versions of Poco which didn't bundle a CMake config this variable was provided by either a distro specific patch or a vendor-like wrapper package.

Anyway as of version 1.6.0 Poco include a CMake config file (see https://github.com/pocoproject/poco/blob/poco-1.6.0-release/cmake/PocoConfig.cmake.in). So it seems to be fine to remove.

[dirk-thomas]

With #67 merged this needs a rebase.

[rotu]

Rebased