Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement get_actual_qos() for subscriptions #271

Merged
merged 4 commits into from Jun 12, 2019

Conversation

Projects
None yet
2 participants
@mm318
Copy link
Contributor

commented Jun 7, 2019

Currently, publishers have the get_actual_qos() feature/function. It would make sense for subscriptions to have them, too.

add get_actual_qos() feature to subscriptions
Signed-off-by: Miaofei <miaofei@amazon.com>
@ivanpauno
Copy link
Contributor

left a comment

Same comment about code duplication that in ros2/rmw_fastrtps#287 (review).

return RMW_RET_ERROR;
}

if (!data_reader) {

This comment has been minimized.

Copy link
@ivanpauno

ivanpauno Jun 7, 2019

Contributor

Duplicated in L342 (check similar comment in ros2/rmw_connext#358 (comment)).

This comment has been minimized.

Copy link
@mm318

mm318 Jun 9, 2019

Author Contributor

Done.

mm318 added some commits Jun 9, 2019

reduce duplicate code
Signed-off-by: Miaofei <miaofei@amazon.com>
remove duplicate check
Signed-off-by: Miaofei <miaofei@amazon.com>
@mm318

This comment has been minimized.

Copy link
Contributor Author

commented Jun 9, 2019

Refactored to avoid duplicate code. Thanks!

use visibility macros
Signed-off-by: Miaofei <miaofei@amazon.com>

@ivanpauno ivanpauno merged commit 8457b00 into ros2:master Jun 12, 2019

1 check passed

DCO DCO
Details
@ivanpauno

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.