Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert ROS 1 nodes' stdout. #247

Merged
merged 1 commit into from Mar 13, 2020
Merged

Assert ROS 1 nodes' stdout. #247

merged 1 commit into from Mar 13, 2020

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Mar 12, 2020

As logs go out stdout and not stderr in ROS 1.

This pull request fixes recent nightly packaging jobs' test failures.

  • Packaging Linux Build Status

@hidmic
Assert ROS 1 nodes' stdout.
605f60c 
As logs go out stdout and not stderr.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic added the bug Something isn't working label Mar 12, 2020
@hidmic hidmic requested a review from dirk-thomas March 12, 2020 19:34
@hidmic
Copy link
Contributor Author

hidmic commented Mar 13, 2020

Alright, merging.

@hidmic hidmic merged commit 0c7c175 into master Mar 13, 2020
@delete-merged-branch delete-merged-branch bot deleted the hidmic/assert-ros1-nodes-stdout branch March 13, 2020 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@dirk-thomas dirk-thomas dirk-thomas approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hidmic @clalancette @dirk-thomas