Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uncrustify failed with error code 1 while colcon test for msg packages #648

Closed
yechun1 opened this Issue Jan 22, 2019 · 5 comments

Comments

Projects
None yet
4 participants
@yechun1
Copy link

yechun1 commented Jan 22, 2019

Bug report

Required Info:

  • Operating System:
    • Ubuntu 18.04
  • Installation type:
    • binaries installation, Issue find after Update Crystal repos file for Patch release 1. #646
  • Version or commit hash:
  • DDS implementation:
  • Client library (if applicable):

Steps to reproduce issue

apt-get install ros-crystal-dekstop (and apt-get upgrade to latest version)
source /opt/ros/crystal/setup.bash
<clone crystal source to src_crystal>
colcon build --base-paths src_crystal/ros2/rcl_interfaces/
colcon test --base-paths src_crystal/ros2/rcl_interfaces/

Expected behavior

build without failures

Actual behavior

build with test failures

Additional information


ros2_ws$ colcon build --base-paths src_crystal/ros2/rcl_interfaces/
Starting >>> builtin_interfaces
Starting >>> lifecycle_msgs
Finished <<< builtin_interfaces [10.6s]                                                                        
Starting >>> action_msgs
Starting >>> rcl_interfaces
Starting >>> rosgraph_msgs
Finished <<< rosgraph_msgs [13.7s]                                                                                                
Finished <<< action_msgs [27.5s]                                                                            
Starting >>> test_msgs
Finished <<< lifecycle_msgs [49.4s]                                                                                              
[Processing: rcl_interfaces, test_msgs]                                                                     
Finished <<< rcl_interfaces [1min 15s]                                                                          
Finished <<< test_msgs [1min 5s]                                

Summary: 6 packages finished [1min 43s]
ros2_ws$ colcon test --base-paths src_crystal/ros2/rcl_interfaces/
Starting >>> builtin_interfaces
Starting >>> lifecycle_msgs
--- stderr: builtin_interfaces                                                       
Errors while running CTest
---
Finished <<< builtin_interfaces [9.57s]	[ with test failures ]
Starting >>> action_msgs
Starting >>> rcl_interfaces
Starting >>> rosgraph_msgs
Finished <<< rcl_interfaces [0.85s]                                                                                            
--- stderr: lifecycle_msgs                                                                             
Errors while running CTest
---
Finished <<< lifecycle_msgs [16.4s]	[ with test failures ]
--- stderr: rosgraph_msgs                                                     
Errors while running CTest
---
Finished <<< rosgraph_msgs [9.55s]	[ with test failures ]
--- stderr: action_msgs                     
Errors while running CTest
---
Finished <<< action_msgs [12.4s]	[ with test failures ]
Starting >>> test_msgs
[Processing: test_msgs]                   
--- stderr: test_msgs                     
Errors while running CTest
---
Finished <<< test_msgs [36.5s]	[ with test failures ]

Summary: 6 packages finished [58.6s]
  5 packages had stderr output: action_msgs builtin_interfaces lifecycle_msgs rosgraph_msgs test_msgs
  5 packages had test failures: action_msgs builtin_interfaces lifecycle_msgs rosgraph_msgs test_msgs

cat log/latest_test/action_msgs/stdout_stderr.log

3: Test command: /usr/bin/python3 "-u" "/opt/ros/crystal/share/ament_cmake_test/cmake/run_test.py" "/data/proj/ros2_ws/build/action_msgs/test_results/action_msgs/uncrustify_rosidl_generated_cpp.xunit.xml" "--package-name" "action_msgs" "--output-file" "/data/proj/ros2_ws/build/action_msgs/ament_uncrustify/uncrustify_rosidl_generated_cpp.txt" "--command" "/opt/ros/crystal/bin/ament_uncrustify" "--xunit-file" "/data/proj/ros2_ws/build/action_msgs/test_results/action_msgs/uncrustify_rosidl_generated_cpp.xunit.xml" "--linelength" "999" "/data/proj/ros2_ws/build/action_msgs/rosidl_generator_cpp/action_msgs"
3: Test timeout computed to be: 60
3: -- run_test.py: invoking following command in '/data/proj/ros2_ws/src_crystal/ros2/rcl_interfaces/action_msgs':
3:  - /opt/ros/crystal/bin/ament_uncrustify --xunit-file /data/proj/ros2_ws/build/action_msgs/test_results/action_msgs/uncrustify_rosidl_generated_cpp.xunit.xml --linelength 999 /data/proj/ros2_ws/build/action_msgs/rosidl_generator_cpp/action_msgs
3: Option<UNUM>: at /tmp/uncrustify_34uitw5v:2310: requested value 999 for option code_width is greater than the maximum value 0
3: Option<UNUM>: at /tmp/uncrustify_34uitw5v:2310: Expected unsigned number for code_width; got '999'
3: Output prefix: /tmp/uncrustify_gvx16fog/
3: Output suffix: .uncrustify
3: Parsing: /data/proj/ros2_ws/build/action_msgs/rosidl_generator_cpp/action_msgs/msg/goal_info.hpp as language CPP
3: Parsing: /data/proj/ros2_ws/build/action_msgs/rosidl_generator_cpp/action_msgs/msg/goal_info__struct.hpp as language CPP
3: Parsing: /data/proj/ros2_ws/build/action_msgs/rosidl_generator_cpp/action_msgs/msg/goal_info__traits.hpp as language CPP
3: Parsing: /data/proj/ros2_ws/build/action_msgs/rosidl_generator_cpp/action_msgs/msg/goal_status.hpp as language CPP
3: Parsing: /data/proj/ros2_ws/build/action_msgs/rosidl_generator_cpp/action_msgs/msg/goal_status__struct.hpp as language CPP
3: Parsing: /data/proj/ros2_ws/build/action_msgs/rosidl_generator_cpp/action_msgs/msg/goal_status__traits.hpp as language CPP
3: Parsing: /data/proj/ros2_ws/build/action_msgs/rosidl_generator_cpp/action_msgs/msg/goal_status_array.hpp as language CPP
3: Parsing: /data/proj/ros2_ws/build/action_msgs/rosidl_generator_cpp/action_msgs/msg/goal_status_array__struct.hpp as language CPP
3: Parsing: /data/proj/ros2_ws/build/action_msgs/rosidl_generator_cpp/action_msgs/msg/goal_status_array__traits.hpp as language CPP
3: Parsing: /data/proj/ros2_ws/build/action_msgs/rosidl_generator_cpp/action_msgs/srv/cancel_goal.hpp as language CPP
3: Parsing: /data/proj/ros2_ws/build/action_msgs/rosidl_generator_cpp/action_msgs/srv/cancel_goal__request.hpp as language CPP
3: Parsing: /data/proj/ros2_ws/build/action_msgs/rosidl_generator_cpp/action_msgs/srv/cancel_goal__request__struct.hpp as language CPP
3: Parsing: /data/proj/ros2_ws/build/action_msgs/rosidl_generator_cpp/action_msgs/srv/cancel_goal__request__traits.hpp as language CPP
3: Parsing: /data/proj/ros2_ws/build/action_msgs/rosidl_generator_cpp/action_msgs/srv/cancel_goal__response.hpp as language CPP
3: Parsing: /data/proj/ros2_ws/build/action_msgs/rosidl_generator_cpp/action_msgs/srv/cancel_goal__response__struct.hpp as language CPP
3: Parsing: /data/proj/ros2_ws/build/action_msgs/rosidl_generator_cpp/action_msgs/srv/cancel_goal__response__traits.hpp as language CPP
3: Parsing: /data/proj/ros2_ws/build/action_msgs/rosidl_generator_cpp/action_msgs/srv/cancel_goal__struct.hpp as language CPP
3: Parsing: /data/proj/ros2_ws/build/action_msgs/rosidl_generator_cpp/action_msgs/srv/cancel_goal__traits.hpp as language CPP
3:-
3: The invocation of 'uncrustify' failed with error code 1: Command '['/opt/ros/crystal/bin/uncrustify', '-c', '/tmp/uncrustify_34uitw5v', '--prefix', '/tmp/uncrustify_gvx16fog', '--suffix', '.uncrustify', '/data/proj/ros2_ws/build/action_msgs/rosidl_generator_cpp/action_msgs/msg/goal_info.hpp', '/data/proj/ros2_ws/build/action_msgs/rosidl_generator_cpp/action_msgs/msg/goal_info__struct.hpp', '/data/proj/ros2_ws/build/action_msgs/rosidl_generator_cpp/action_msgs/msg/goal_info__traits.hpp', '/data/proj/ros2_ws/build/action_msgs/rosidl_generator_cpp/action_msgs/msg/goal_status.hpp', '/data/proj/ros2_ws/build/action_msgs/rosidl_generator_cpp/action_msgs/msg/goal_status__struct.hpp', '/data/proj/ros2_ws/build/action_msgs/rosidl_generator_cpp/action_msgs/msg/goal_status__traits.hpp', '/data/proj/ros2_ws/build/action_msgs/rosidl_generator_cpp/action_msgs/msg/goal_status_array.hpp', '/data/proj/ros2_ws/build/action_msgs/rosidl_generator_cpp/action_msgs/msg/goal_status_array__struct.hpp', '/data/proj/ros2_ws/build/action_msgs/rosidl_generator_cpp/action_msgs/msg/goal_status_array__traits.hpp', '/data/proj/ros2_ws/build/action_msgs/rosidl_generator_cpp/action_msgs/srv/cancel_goal.hpp', '/data/proj/ros2_ws/build/action_msgs/rosidl_generator_cpp/action_msgs/srv/cancel_goal__request.hpp', '/data/proj/ros2_ws/build/action_msgs/rosidl_generator_cpp/action_msgs/srv/cancel_goal__request__struct.hpp', '/data/proj/ros2_ws/build/action_msgs/rosidl_generator_cpp/action_msgs/srv/cancel_goal__request__traits.hpp', '/data/proj/ros2_ws/build/action_msgs/rosidl_generator_cpp/action_msgs/srv/cancel_goal__response.hpp', '/data/proj/ros2_ws/build/action_msgs/rosidl_generator_cpp/action_msgs/srv/cancel_goal__response__struct.hpp', '/data/proj/ros2_ws/build/action_msgs/rosidl_generator_cpp/action_msgs/srv/cancel_goal__response__traits.hpp', '/data/proj/ros2_ws/build/action_msgs/rosidl_generator_cpp/action_msgs/srv/cancel_goal__struct.hpp', '/data/proj/ros2_ws/build/action_msgs/rosidl_generator_cpp/action_msgs/srv/cancel_goal__traits.hpp']' returned non-zero exit status 1.
3: -- run_test.py: return code 1
3: -- run_test.py: generate result file '/data/proj/ros2_ws/build/action_msgs/test_results/action_msgs/uncrustify_rosidl_generated_cpp.xunit.xml' with failed test
3: -- run_test.py: verify result file '/data/proj/ros2_ws/build/action_msgs/test_results/action_msgs/uncrustify_rosidl_generated_cpp.xunit.xml'
 3/31 Test  #3: uncrustify_rosidl_generated_cpp ...................***Failed    0.31 sec

Feature request

Feature description

Implementation considerations

@yechun1

This comment has been minimized.

Copy link
Author

yechun1 commented Jan 22, 2019

seems all the msgs packages with "ADD_LINTER_TESTS" will test with failures.

@dirk-thomas

This comment has been minimized.

Copy link
Member

dirk-thomas commented Jan 22, 2019

What version of the ros-crystal-uncrustify-vendor do you have installed?

@yechun1

This comment has been minimized.

Copy link
Author

yechun1 commented Jan 22, 2019

$ dpkg -l |grep uncrustify-vendor
ii ros-crystal-uncrustify-vendor 1.1.0-0bionic.20190114.183025 amd64 Wrapper around uncrustify, providing nothing but a dependency on uncrustify, on some systems.

@dirk-thomas

This comment has been minimized.

Copy link
Member

dirk-thomas commented Jan 23, 2019

I can reproduce the test failures (using the same version of the Debian package). The problem seems to be that the new uncrustify version was released into Crystal but not the changes in the message generator packages related to it (e.g. ros2/rosidl#341).

@nuclearsandwich I think this needs a patch release for all the repos referenced from ros2/rosidl#340 which haven't been released since the MAX_LINE_LENGTH argument was changes, e.g. rosidl, rcutils, rclcpp.

@yechun1

This comment has been minimized.

Copy link
Author

yechun1 commented Feb 22, 2019

Issue fixed by Cyrstal Patch Release 2, close it.

@yechun1 yechun1 closed this Feb 22, 2019

@tfoote tfoote removed the ready label Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.