Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Crystal Patch Release 3 #656
This issue will track the list of changes that should be included in the next Crystal patch release.
Repos file aggregating backport branches against crystal development branches for CI. gist
Repositories ready for release
PRs which need a backport for this patch release:
Workaround for nested messages in actions. ros2/rosidl#348
Fix the include directory order of overlay workspaces.
Export the CMake logic to find ROS 1 packages through the ros1_bridge.
Actions support in Python
Remove make_notifier() call in flake8 to fix ROS 2 CI.
SROS2 XML and XSLT permissions transforms (and follow-on)
Changes in progress for this patch release.
Proposed changes which have been dropped or deferred
Display the robot description correctly in rviz. Breaks API. Will not be released into Crystal.
Add idlpp option to maintian include file namespace. Not a release blocker. May be released in a future patch release.
All pull requests being released
Organized by repository and backport PR
PR exporting the cmake logic to find ros1 packages through the ros1_bridge: ros2/ros1_bridge#164…
On Tue, Feb 19, 2019 at 4:17 PM Dirk Thomas ***@***.***> wrote: PR fixing the include dir order of overlay workspaces: ament/ament_cmake#157 <ament/ament_cmake#157> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#656 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFKzYaCvH0FwzpMErGQAmVCOS9aleLqrks5vPJQcgaJpZM4a86QP> .
This pull request has since been reverted and the re-application is still in progress. We won't wait for that PR to settle, if it makes this patch release that's fantastic. If not it can go into the next one after it's ready.
referenced this issue
Mar 7, 2019
Updated the issue body with the open backport PRs. Rather than try and track the backports as both "in progress" work and backports of needed features from development branches I organized them all by what they backport. That leaves the In progress list for tasks which may still have development required before even a backport is ready.
I've also put up a link to a gist I'll try to keep in sync with the current status of backport branches so we can use it to test incoming PRs against Crystal patch 3.
referenced this issue
Mar 10, 2019
The backported changes in
The installation documentation has been updated in ros2/ros2_documentation#138, but I'll highlight the changes here:
Depending on the platform, users may need to get the additional dependency:
There are currently no rosdep macos rules for
Based on ros/rosdistro#20560 (comment) it looks like it will stay the case for now until we have a way to specify / test which pip is used to install a package via rosdep.
@nuclearsandwich I am sorry for a late chime in but I think that these 2 bugs area serious:
@dejanpan the window is definitely closed for new changes in patch release 3. Since the Fast-RTPS issues have been present in Crystal since its release rather than recent regressions, I am opting not to delay this patch release and instead we can target these fixes for the next one (#668).
Open Robotics had a brief discussion about whether or not the improvements in Fast-RTPS 1.7.1/1.7.2 are worth allowing breaking changes and I expect that discussion to continue in #668.
In the meantime, documenting these issues is a important, although I think adding them to the documentation for Crystal makes more sense than putting them in the release notes since they're not new, just newly reported. I will definitely add a remark re-linking the Crystal release page and known issues in the release announcement.