Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crystal Patch Release 4 #668

Closed
nuclearsandwich opened this Issue Mar 14, 2019 · 9 comments

Comments

Projects
None yet
4 participants
@nuclearsandwich
Copy link
Member

nuclearsandwich commented Mar 14, 2019

This issue will track the list of changes that should be included in the next Crystal patch release. The date for this patch release is scheduled for 2019-04-04 and will be determined by a critical mass of desired changes ready to be released.


Changes proposed for backport this patch release

Changes in progress for this release


All pull requests included in this release. Organized by repository and backport PR.

eProsima/Fast-RTPS The changes in Fast-RTPS are discussed in ros2/ros2#669.
For a complete summary of changes see: b48ce9d...v1.7.2.
ros2/launch
ros2/rclcpp
ros2/rclpy
ros2/rmw_fastrtps

@nuclearsandwich nuclearsandwich self-assigned this Mar 14, 2019

@nuclearsandwich nuclearsandwich referenced this issue Mar 14, 2019

Closed

Crystal Patch Release 3 #656

10 of 10 tasks complete
@nuclearsandwich

This comment has been minimized.

Copy link
Member Author

nuclearsandwich commented Mar 14, 2019

As mentioned previously and discussed internally, (calling @clalancette as the current leader of that discussion), we should consider updating the version of Fast-RTPS in Crystal to resolve ros2/rmw_fastrtps#257 and ros2/rmw_fastrtps#258.

@clalancette

This comment has been minimized.

Copy link
Contributor

clalancette commented Mar 15, 2019

I'm now tracking the Fast-RTPS issue at #669; I'll put further notes in there while we figure out what to do for Crystal patch release 4.

@wjwwood

This comment has been minimized.

Copy link
Member

wjwwood commented Mar 27, 2019

Can we add a partial cherry-pick on the launch repository?

ros2/launch@632ef1f#diff-970fc3c5d394ad33c14e4f9fe55288ceR113

Via

@wjwwood

This comment has been minimized.

Copy link
Member

wjwwood commented Mar 27, 2019

@stonier FYI

@nuclearsandwich

This comment has been minimized.

Copy link
Member Author

nuclearsandwich commented Apr 4, 2019

A possible regression in rclcpp_action, which wasn't released this round and thus why it wasn't caught during the backport process, has been found ros2/rclcpp#683.

@nuclearsandwich

This comment has been minimized.

Copy link
Member Author

nuclearsandwich commented Apr 5, 2019

Full CI with a fix for ros2/rclcpp#683. If this comes back with no unexpected failures we'll re-release rclcpp and include it in this patch release.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status
@nuclearsandwich

This comment has been minimized.

Copy link
Member Author

nuclearsandwich commented Apr 6, 2019

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

nuclearsandwich added a commit that referenced this issue Apr 8, 2019

Crystal patch 4 (#683)
Update the crystal branch to the patch 4 releases.


Connects to #668. Closes #668.
@nuclearsandwich

This comment has been minimized.

Copy link
Member Author

nuclearsandwich commented Apr 8, 2019

Packaging jobs

  • Linux Bionic Build Status
  • Linux Xenial Build Status
  • Linux Bionic (ARM64) Build Status
  • Linux Xenial (ARM64) Build Status
  • macOS Build Status
  • Windows Build Status
  • Windows Debug Build Status
@nuclearsandwich

This comment has been minimized.

Copy link
Member Author

nuclearsandwich commented Apr 10, 2019

I keep forgetting that PRs to the crystal branch won't auto-close issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.