Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable modern CMake usage #904

Closed
dirk-thomas opened this issue Apr 21, 2020 · 4 comments
Closed

enable modern CMake usage #904

dirk-thomas opened this issue Apr 21, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@dirk-thomas
Copy link
Member

dirk-thomas commented Apr 21, 2020

This is a meta ticket to track progress toward modern CMake (exporting targets and using interface targets) instead of classic CMake (CMake variables ending in _INCLUDE_DIRS and _LIBRARIES).

@dirk-thomas dirk-thomas added the enhancement New feature or request label Apr 21, 2020
This was referenced Apr 21, 2020
@dirk-thomas
Copy link
Member Author

dirk-thomas commented Apr 23, 2020

With the above referenced changes it is possible to build e.g. demo_nodes_cpp without using classic CMake variables within the ROS packages (external system dependencies might not provide modern CMake targets but only offer classic CMake variables).

To ensure that this is actually the case I made the following ament_cmake functions no-ops:

  • ament_export_definitions
  • ament_export_include_directories
  • ament_export_libraries
  • ament_export_link_flags

@dirk-thomas
Copy link
Member Author

dirk-thomas commented May 1, 2020

See #915 for related fixes.

@dirk-thomas
Copy link
Member Author

dirk-thomas commented May 4, 2020

With the PR for the Fox migration notes ready and the rosbag2 follow up ticketed I will go ahead and close this.

@RFRIEDM-Trimble
Copy link

RFRIEDM-Trimble commented Jul 14, 2022

Big win, ROSIDL just merged this PR adding alias targets, and it's being backported to Humble. Most ROS2 packages should now be able to call target_link_libraries with ALIAS targets for all their dependencies instead of ament_target_dependencies.
ros2/rosidl#605

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants