Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a PR check for viability and formatting #1135

Merged
merged 2 commits into from May 10, 2021

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Apr 22, 2021

This change adds a simple-and-sweet import/export round-trip to verify that all of the repository information is viable and that the format matches what vcstool exports.

This change adds some YAML format validation (including alphabetical ordering), as well as a validation pass using vcstool.

Requires #1134

@cottsay cottsay self-assigned this Apr 22, 2021
@cottsay cottsay force-pushed the cottsay/import_export_check branch from 8a4fb49 to 6711e56 Compare April 23, 2021 00:03
@cottsay cottsay marked this pull request as ready for review April 23, 2021 00:04
@cottsay
Copy link
Member Author

cottsay commented Apr 23, 2021

Oh, lame. Looks like a tag gets exported as a SHA, so Fast-CDR makes this not work right.

I'll convert this back to draft - we might be able to get the behavior we want from vcstool with a modifier.

@cottsay cottsay marked this pull request as draft April 23, 2021 00:15
@cottsay cottsay force-pushed the cottsay/import_export_check branch from 6711e56 to 28f2024 Compare April 27, 2021 21:06
@cottsay cottsay marked this pull request as ready for review April 27, 2021 21:07
Signed-off-by: Scott K Logan <logans@cottsay.net>
@cottsay cottsay force-pushed the cottsay/import_export_check branch from 28f2024 to 5415b0f Compare April 27, 2021 21:08
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it.

@nuclearsandwich
Copy link
Member

Very cool! Is there a way to run this against the current $ROSDISTRO-{,release} branches so that we don't immediately introduce errors from day 0?

@cottsay
Copy link
Member Author

cottsay commented Apr 28, 2021

Is there a way to run this against the current $ROSDISTRO-{,release} branches so that we don't immediately introduce errors from day 0?

The workflow will need to be introduced into each branch that we want to protect, so we won't get any breakage on day 0.

@nuclearsandwich
Copy link
Member

The workflow will need to be introduced into each branch that we want to protect, so we won't get any breakage on day 0

Works for me. I thought that workflows from the default branch would be a applied everywhere given the on: pull_requests: branches: '*' but I don't find any current docs that say as much.

@cottsay cottsay merged commit 3d98527 into master May 10, 2021
@delete-merged-branch delete-merged-branch bot deleted the cottsay/import_export_check branch May 10, 2021 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants