Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the ros2.repos file for Space ROS #1187

Merged
merged 3 commits into from Sep 15, 2021

Conversation

mjeronimo
Copy link
Contributor

This was generated using the latest Space ROS package list, with a few changes and additions:

  • Updated the ament_lint branch to use 'spaceros' instead of 'master'

  • Added ros2cli for convenient acces to the ros2 utility. In the future we may have a finer, layered approach to the package lists, but for now it will be convenient to have the ros2 utility available.

  • Added rosidl_runtime_py since it is required by some of the ros2 sub-commands.

Signed-off-by: Michael Jeronimo michael.jeronimo@openrobotics.org

This was generated using the latest Space ROS package list, with
a few changes and additions:

* Updated the ament_lint branch to use 'spaceros' instead of 'master'

* Added ros2cli for convenient acces to the ros2 utility. In the future
  we may have a finer, layered approach to the package lists, but for now
  it will be convenient to have the ros2 utility available.

* Added rosidl_runtime_py since it is required by some of the ros2 subcommands.

Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
ros2.repos Outdated Show resolved Hide resolved
ros2.repos Outdated Show resolved Hide resolved
@wjwwood
Copy link
Member

wjwwood commented Sep 15, 2021

I don't see ros2cli or rosidl_runtime_py in the diff, is that expected?

@mjeronimo
Copy link
Contributor Author

Regarding ros2cli and rosidl_runtime_py: They weren't in spaceros-pkgs.txt from which I generated the ros2.repos file. So, in that sense, they were "added." However, they were already in the previous ros2.repos file on the spaceros branch, which is a much larger set of packages (and not generated from the package list). So, relative to that, they were already present and won't show up in the diffs.

@wjwwood
Copy link
Member

wjwwood commented Sep 15, 2021

That's a good question, maybe @shonigmann can comment. I thought we'd decided to remove fastrtps and connext, but looking again I think we just said that's what we wanted to do but didn't prune the list.

@wjwwood
Copy link
Member

wjwwood commented Sep 15, 2021

Updated the ament_lint branch to use 'spaceros' instead of 'master'

I don't see this in the diff either?

@mjeronimo
Copy link
Contributor Author

mjeronimo commented Sep 15, 2021

Same issue. My comments were probably misleading because they were relative to the input spaceros-pkgs list. The new ros2.repos was generated from this list using the Makefile in sa-spaceros which calls the rosinstall_generator using the 'rolling' branch since there is no spaceros distro yet in rosdistro, and so required an update to the ament_lint branch name. However, the ament_lint branch was already 'spaceros' in the existing ros2.repos file against which the generated file is diffed.

@wjwwood
Copy link
Member

wjwwood commented Sep 15, 2021

Got it.

Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this ok then, we'll just have to update it later as the source material changes.

Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
@shonigmann
Copy link

That's a good question, maybe @shonigmann can comment. I thought we'd decided to remove fastrtps and connext, but looking again I think we just said that's what we wanted to do but didn't prune the list.

That's correct - the .repos file was just generated using rosinstall_generator to include all dependencies, as is. I didn't go through and prune the list because I thought it may cause build issues. In any case, the vnv focus list should still represent the packages who's output we are interested in looking at.

@mjeronimo
Copy link
Contributor Author

Ok, I'll prune those from this repos file.

Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
@mjeronimo mjeronimo merged commit c3e9373 into spaceros Sep 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the mjeronimo/update-spaceros-repos branch September 15, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants