Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TSC section #144

Merged
merged 7 commits into from Apr 4, 2019

Conversation

Projects
None yet
5 participants
@gerkey
Copy link
Member

gerkey commented Mar 21, 2019

Create a public canonical location for TSC membership.

@tfoote tfoote added the in progress label Mar 21, 2019

@gerkey gerkey added ready and removed in progress labels Mar 21, 2019

@dirk-thomas

This comment has been minimized.

Copy link
Member

dirk-thomas commented Mar 21, 2019

How about moving this information to a separate page? The content looks pretty specific for the entry point index page.

@gerkey

This comment has been minimized.

Copy link
Member Author

gerkey commented Mar 21, 2019

Sure, I can do that. Before I make that structural change, any comments on the format or style? (This is my first PR in this repo and want to make sure that I'm following whatever the rules are.)

@dirk-thomas

This comment has been minimized.

Copy link
Member

dirk-thomas commented Mar 21, 2019

LGTM

@mjcarroll mjcarroll added in progress and removed ready labels Mar 21, 2019

@dirk-thomas

This comment has been minimized.

Copy link
Member

dirk-thomas commented Mar 26, 2019

LGTM. Please see the CI failure if the page should be referenced anywhere.

@gerkey

This comment has been minimized.

Copy link
Member Author

gerkey commented Mar 26, 2019

Ah, neat that it checks to ensure the page is referenced. In any case I'm not done yet (still going to add info on working groups).

@gerkey

This comment has been minimized.

Copy link
Member Author

gerkey commented Mar 26, 2019

Note to self: add company logos.

gerkey added some commits Mar 26, 2019

gerkey and others added some commits Apr 1, 2019

Brian Gerkey

@gerkey gerkey added ready and removed in progress labels Apr 2, 2019

@gerkey

This comment has been minimized.

Copy link
Member Author

gerkey commented Apr 2, 2019

To aid with review, here's a screenshot showing the rendered table based on a local build:

image

@hidmic

hidmic approved these changes Apr 4, 2019

Copy link
Collaborator

hidmic left a comment

LGTM too!

@gerkey gerkey merged commit 78f3a09 into master Apr 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@delete-merged-branch delete-merged-branch bot deleted the add-tsc-section branch Apr 4, 2019

@tfoote tfoote removed the ready label Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.