Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Why ROS 2?" brochure (plus a few tweaks) #284

Merged
merged 1 commit into from Jun 19, 2019

Conversation

Projects
None yet
2 participants
@gerkey
Copy link
Member

commented Jun 19, 2019

The primary change here is to add the new "Why ROS 2?" brochure,
which is linked from a new Marketing page (to allow for more
materials to be added in the future). While I was in there, I
made a few other changes:

  • Move the TSC charter PDF into this repo to avoid the need to
    update the link in the future because of changes to the CDN
    configuration used by Discourse (#282). I'm adding the brochure
    PDFs for the same reason.

  • Remove "ROS 2" from the titles of a few pages because (a) it's
    redundant (this whole repo is about ROS 2) and (b) it makes the
    navigation menu look better to not have such long page titles.

Brian Gerkey
Add "Why ROS 2?" brochure (plus a few tweaks)
The primary change here is to add the new "Why ROS 2?" brochure,
which is linked from a new Marketing page (to allow for more
materials to be added in the future). While I was in there, I
made a few other changes:

 * Move the TSC charter PDF into this repo to avoid the need to
   update the link in the future because of changes to the CDN
   configuration used by Discourse (#282). I'm adding the brochure
   PDFs for the same reason.

 * Remove "ROS 2" from the titles of a few pages because (a) it's
   redundant (this whole repo is about ROS 2) and (b) it makes the
   navigation menu look better to not have such long page titles.

@gerkey gerkey added the ready label Jun 19, 2019

@wjwwood

This comment has been minimized.

Copy link
Member

commented Jun 19, 2019

because (a) it's redundant (this whole repo is about ROS 2)

That's true, but it's hosted on index.ros.org which aside from hosting these docs also has packages in it from ROS 1 and ROS 2. Anyway I agree with your pr, but would honestly like to see the documentation hosted somewhere else, either docs.ros.org/ros2 or docs.ros2.org.

@wjwwood wjwwood merged commit d406ca2 into master Jun 19, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@delete-merged-branch delete-merged-branch bot deleted the add_brochure branch Jun 19, 2019

@gerkey

This comment has been minimized.

Copy link
Member Author

commented Jun 24, 2019

FYI, proper deployment of this change was hung up on ros-infrastructure/rosindex#170. With the fix in ros-infrastructure/rosindex#171, we should be seeing the brochure and charter PDFs actually show up on the live site soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.