Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance parameter documentation in node-arguments.rst #297

Merged
merged 1 commit into from Sep 13, 2019

Conversation

@nickolai-voyage
Copy link
Contributor

commented Jul 8, 2019

Add info about either declaring parameters or allowing undeclared parameters

@hidmic

This comment has been minimized.

Copy link
Collaborator

commented Jul 15, 2019

@nickolai-voyage friendly ping

@hidmic

This comment has been minimized.

Copy link
Collaborator

commented Sep 3, 2019

@nickolai-voyage are you planning to wrap this up?

Enhance parameter documentation in node-arguments.rst
Add info about either declaring parameters or automatically declaring
parameters passed in from override. Without those settings the example
in the tutorial fails.
@nickolai-voyage

This comment has been minimized.

Copy link
Contributor Author

commented Sep 3, 2019

Thanks for the ping, made @wjwwood's changes, how does that look?

@wjwwood wjwwood merged commit ac24308 into ros2:master Sep 13, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nickolai-voyage nickolai-voyage deleted the nickolai-voyage:patch-3 branch Sep 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.