Update package dependencies for pub/sub tutorial #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package dependencies given in the tutorial should be both build and execution dependencies, so I change the dependency tags to just 'depend'. See discussion here: https://github.com/ros2/ros2_documentation/pull/366/files#r397961159
togaen
added a commit
to togaen/ros2_documentation
that referenced
this pull request
Apr 9, 2020
The C++ package dependencies listed in the tutorial for custom `msg`/`srv` files should be `depend` instead of `exec_depend`. A similar change was made in ros2#574
maryaB-osr
pushed a commit
that referenced
this pull request
Apr 9, 2020
The C++ package dependencies listed in the tutorial for custom `msg`/`srv` files should be `depend` instead of `exec_depend`. A similar change was made in #574
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package dependencies given in the tutorial should be both build and execution dependencies, so I change the dependency tags to just 'depend'. See discussion here: https://github.com/ros2/ros2_documentation/pull/366/files#r397961159