add support for parameter prefixes in ros2 param list #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikaelarguedas
force-pushed
the
param_list_prefixes
branch
from
fb3ac5d
to
e654c3e
Compare
|
CI just for linters: |
mikaelarguedas
added
in review
wjwwood
reviewed
Aug 8, 2018
ros2param/ros2param/verb/list.py
Outdated
| @@ -46,6 +49,9 @@ def main(self, *, args): # noqa: D102 | |||
| if args.node_name not in node_names: | |||
| return 'Node not found' | |||
| node_names = [args.node_name] | |||
| param_prefixes = [] | |||
| if args.param_prefixes is not None: | |||
| param_prefixes = [args.param_prefixes] | |||
There was a problem hiding this comment.
Won't this always be a list of 1?
sloretz
reviewed
Aug 8, 2018
ros2param/ros2param/verb/list.py
Outdated
| @@ -36,6 +36,9 @@ def add_arguments(self, parser, cli_name): # noqa: D102 | |||
| parser.add_argument( | |||
| '--include-hidden-nodes', action='store_true', | |||
| help='Consider hidden nodes as well') | |||
| parser.add_argument( | |||
| '--param-prefixes', nargs='?', | |||
There was a problem hiding this comment.
I'm not sure nargs='?' is the right choice because it allows an empty --param-prefixes
$ ros2 param list --param-prefixes
listener:
bar.baz
foo
foo.bar
foo.bar.baz
Is the intent to allow multiple prefixes to be specified? If so, nargs='+' or action='append' might be better choices.
|
Thanks for the feedback, I simplified the logic in c67f9d8 and it should now support multiple prefixes |
sloretz
approved these changes
Aug 8, 2018
esteve
pushed a commit
to esteve/ros2cli
that referenced
this pull request
Dec 16, 2022
esteve
pushed a commit
to esteve/ros2cli
that referenced
this pull request
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.