Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add topic pub prototype completer #299

Merged
merged 1 commit into from Aug 7, 2019

Conversation

@artivis
Copy link
Contributor

commented Jul 17, 2019

Add a message prototype completer to ros2 topic pub.
E.g.

$ ros2 topic pub /chatter geometry_msgs/msg/Pose [tab][tab]
-1
-n
--node-name
--once
-p
position:^J  x: 0.0^J  y: 0.0^J  z: 0.0^Jorientation:^J  x: 0.0^J  y: 0.0^J  z: 0.0^J  w: 0.0
--print
--qos-durability
--qos-profile
--qos-reliability
-r
--rate

Not very pretty but one can at least figure out the first few characters of the message body.
Then,

$ ros2 topic pub /chatter geometry_msgs/msg/Pose "p [tab]

resolves to,

ros2 topic pub /chatter geometry_msgs/msg/Pose "position:
  x: 0.0
  y: 0.0
  z: 0.0
orientation:
  x: 0.0
  y: 0.0
  z: 0.0
  w: 0.0"

This follows the work initiated in #298.

Signed-off-by: artivis jeremie.deray@canonical.com

@artivis artivis force-pushed the artivis:feature/topic-pub-proto-completer branch from 8c2a921 to d56f4ac Jul 17, 2019
@artivis artivis force-pushed the artivis:feature/topic-pub-proto-completer branch 2 times, most recently from fe7b2f2 to 3d113f8 Jul 26, 2019
Copy link
Contributor

left a comment

LGTM

ros2topic/ros2topic/api/__init__.py Outdated Show resolved Hide resolved
Signed-off-by: artivis <jeremie.deray@canonical.com>
@artivis artivis force-pushed the artivis:feature/topic-pub-proto-completer branch from 3d113f8 to 3f6341b Aug 7, 2019
@artivis

This comment has been minimized.

Copy link
Contributor Author

commented Aug 7, 2019

@ivanpauno updated the PR to benefit from ros2/rosidl_python#78

@ivanpauno

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

Sanity check:

  • Linux: Build Status
@ivanpauno ivanpauno merged commit a5b129a into ros2:master Aug 7, 2019
1 check passed
1 check passed
DCO DCO
Details
@kyrofa kyrofa referenced this pull request Sep 4, 2019
27 of 29 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.