Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service call prototype completer #300

Merged

Conversation

@artivis
Copy link
Contributor

commented Jul 17, 2019

Add a service request prototype completer to ros2 service call.
E.g.

$ ros2 service call /add_two_ints example_interfaces/srv/AddTwoInts [tab][tab]
a:\ 0\^Jb:\ 0\  -r              --rate

Not very pretty but one can at least figure out the first few characters of the request body.
Then,

$ ros2 service call /add_two_ints example_interfaces/srv/AddTwoInts "a [tab]

resolves to,

ros2 service call /add_two_ints example_interfaces/srv/AddTwoInts "a: 0
b: 0"

This follows the work initiated in #298.

Signed-off-by: artivis jeremie.deray@canonical.com

@artivis artivis force-pushed the artivis:feature/service-call-prototype-completer branch 2 times, most recently from f3e4dc7 to 691f115 Jul 17, 2019
@artivis artivis force-pushed the artivis:feature/service-call-prototype-completer branch 2 times, most recently from b85e04c to e623ffc Jul 26, 2019
parts = full_service_type.split('/')
package_name = parts[0]
interface_type = parts[1]
service_type = parts[-1]

This comment has been minimized.

Copy link
@ivanpauno

ivanpauno Aug 2, 2019

Contributor

Same comment as at #301 (comment).

Signed-off-by: artivis <jeremie.deray@canonical.com>
@artivis artivis force-pushed the artivis:feature/service-call-prototype-completer branch from e623ffc to a345e63 Aug 7, 2019
@artivis

This comment has been minimized.

Copy link
Contributor Author

commented Aug 7, 2019

@ivanpauno updated the PR to benefit from ros2/rosidl_python#78

@ivanpauno

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

Sanity check:

  • Linux: Build Status
@ivanpauno ivanpauno merged commit dacbdfd into ros2:master Aug 7, 2019
1 check passed
1 check passed
DCO DCO
Details
@kyrofa kyrofa referenced this pull request Sep 4, 2019
27 of 29 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.