Enable --no-daemon flag for some cli tools #514
Conversation
dawonn-haval
force-pushed
the
fix-no-daemon
branch
from
a0f732c
to
7b5923d
Compare
|
As far as I can tell, the unit tests that are failing run fine on my systems, and shouldn't have been affected by this commit. |
There was a problem hiding this comment.
@dawonn-haval I see three kinds of changes in this patch.
NodeStrategybeing used in CLI verbs such asdelay- Arguments specific to
NodeStrategybeing added where missing. - Misc style changes.
I'd rather stick to (2.) only. (3.) changes are unrelated, and I'm not convinced (1.) is appropriate e.g. ros2 topic bw will always need a direct node to work.
|
@dawonn-haval friendly ping, what do you think of @hidmic's feedback? |
|
I'll push the requested changes momentarily. |
dawonn-haval
force-pushed
the
fix-no-daemon
branch
2 times, most recently
from
534962a
to
d8f8bc6
Compare
|
CI up to
|
|
@dawonn-haval CI reports some linter errors, mind to take a look? |
dawonn-haval
force-pushed
the
fix-no-daemon
branch
from
d8f8bc6
to
89352f7
Compare
|
Rebase Complete. |
|
@dawonn-haval CI still reports linter issues. |
dawonn-haval
force-pushed
the
fix-no-daemon
branch
from
89352f7
to
a4f80e9
Compare
|
These don't show up on my local system or the pull request CI check; I did what the error told me to do and pushed the change, so I hope they are fixed now... Can you run that CI suite again please? |
Fixes ros2#511 Signed-off-by: Dereck Wonnacott <dereck.wonnacott@havalus.com>
dawonn-haval
force-pushed
the
fix-no-daemon
branch
from
a4f80e9
to
6ee7a60
Compare
|
Apparently didn't add the modified files to the commit... sorry, but can you roll it once more? |
|
Alright, finally green. Thank you for your patience @dawonn-haval ! Merging. |
fixes #511
added daemon support to the other topic tools, except pub.
Signed-off-by: Dereck Wonnacott dereck.wonnacott@havalus.com